View Issue Details

IDProjectCategoryView StatusLast Update
0000403Far ManagerPanelpublic2007-12-03 14:43
Reporteralexmitin Assigned Toalexy  
PrioritynormalSeveritymajorReproducibilityhave not tried
Status closedResolutionfixed 
Fixed in Version1.80 alpha 1 
Summary0000403: Not initialized variable used in MessageRemoveConnection()
DescriptionFile: panel.cpp
Line: 2237
Function: MessageRemoveConnection()
Context:
static int MessageRemoveConnection(wchar_t Letter, int &UpdateProfile)
{
...
HKEY hKey;
...
if(RegOpenKeyExW(HKEY_CURRENT_USER,strMsgText,0,KEY_QUERY_VALUE,&hKey)!=ERROR_SUCCESS)
{
  DCDlg[5].Flags|=DIF_DISABLE;
  DCDlg[5].Selected=0;
  IsPersistent=FALSE;
}
else
  DCDlg[5].Selected=Opt.ChangeDriveDisconnetMode;
RegCloseKey(hKey);
...
}

Observations
=============
If RegOpenKeyExW() does not return ERROR_SUCCESS the value of "hKey" is not initialized. Later it will be used in RegCloseKey(). This might cause a crash.
Additional InformationFAR 1.80.0.373
TagsNo tags attached.
Build376

Activities

alexy

2007-12-03 14:43

administrator   bugnote:0000940

376

Issue History

Date Modified Username Field Change
2007-12-03 00:47 alexmitin New Issue
2007-12-03 01:02 vskirdin Status new => assigned
2007-12-03 01:02 vskirdin Assigned To => vskirdin
2007-12-03 13:56 alexy Assigned To vskirdin => alexy
2007-12-03 14:43 alexy Build => 376
2007-12-03 14:43 alexy Status assigned => closed
2007-12-03 14:43 alexy Note Added: 0000940
2007-12-03 14:43 alexy Resolution open => fixed
2007-12-03 14:43 alexy Fixed in Version => 1.80 alpha 1