View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000445 | Far Manager | Build System | public | 2007-12-15 21:25 | 2008-02-24 13:37 |
Reporter | AH | Assigned To | alexy | ||
Priority | normal | Severity | minor | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Fixed in Version | 1.80 alpha 1 | ||||
Summary | 0000445: Makefiles have no -mno-cygwin switch | ||||
Description | Compilation of FAR and plugins under cygwin env will produce files which depend on cygwin library, which is not necessary. Adding -mno-cygwin to all gcc/g++ flags (CCFLAGS, CFLAGS, LNKFLAGS) solves it, it should be harmless to mingw. Patch attached. There is also problem with compilation of files with wrong cases: plugins/multiarc/arc.cpp plugins/multiarc/arj.cpp plugins/multiarc/ha.cpp plugins/multiarc/rar.cpp plugins/multiarc/targz.cpp plugins/multiarc/zip.cpp plugins/multiarc/custom.cpp plugins/multiarc/cab.cpp plugins/multiarc/lzh.cpp According to makefiles it should be: plugins/multiarc/Arc.cpp plugins/multiarc/Arj.cpp plugins/multiarc/TarGz.cpp plugins/multiarc/Ha.cpp plugins/multiarc/Rar.cpp plugins/multiarc/Zip.cpp plugins/multiarc/Custom.cpp plugins/multiarc/Cab.cpp plugins/multiarc/Lzh.cpp Unfortunately under case insensitive systems, it cannot be patched nicely on working copy - http://subversion.tigris.org/faq.html#case-change The best way seems to me to patch directly on repo: "svn mv http://farmanager.com/svn/trunk/plugins/multiarc/ace.cpp http://farmanager.com/svn/trunk/plugins/multiarc/Ace.cpp" | ||||
Tags | No tags attached. | ||||
Build | 399 | ||||
2007-12-15 21:25
|
cygwin.diff (11,939 bytes)
Index: plugins/newarc/src/plugins/7z/makefile_gcc =================================================================== --- plugins/newarc/src/plugins/7z/makefile_gcc (revision 1402) +++ plugins/newarc/src/plugins/7z/makefile_gcc (working copy) @@ -14,8 +14,8 @@ M4 = m4 -P MV = mv -f MKDIR = mkdir -p -CXXFLAGS = -Wall -Wno-non-virtual-dtor -I ../../lib.part/Include -Os -fno-strict-aliasing -funsigned-char -fomit-frame-pointer -fno-rtti -fno-exceptions -LNKFLAGS = -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lole32 -loleaut32 -lcrtdll +CXXFLAGS = -mno-cygwin -Wall -Wno-non-virtual-dtor -I ../../lib.part/Include -Os -fno-strict-aliasing -funsigned-char -fomit-frame-pointer -fno-rtti -fno-exceptions +LNKFLAGS = -mno-cygwin -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lole32 -loleaut32 -lcrtdll all: $(DLLFULLNAME) Index: plugins/newarc/src/plugins/wcx/makefile_gcc =================================================================== --- plugins/newarc/src/plugins/wcx/makefile_gcc (revision 1402) +++ plugins/newarc/src/plugins/wcx/makefile_gcc (working copy) @@ -14,8 +14,8 @@ M4 = m4 -P MV = mv -f MKDIR = mkdir -p -CXXFLAGS = -Wall -I ../../lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions -LNKFLAGS = -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lole32 -lcrtdll +CXXFLAGS = -mno-cygwin -Wall -I ../../lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions +LNKFLAGS = -mno-cygwin -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lole32 -lcrtdll all: $(DLLFULLNAME) Index: plugins/newarc/src/plugins/zip/makefile_gcc =================================================================== --- plugins/newarc/src/plugins/zip/makefile_gcc (revision 1402) +++ plugins/newarc/src/plugins/zip/makefile_gcc (working copy) @@ -14,8 +14,8 @@ M4 = m4 -P MV = mv -f MKDIR = mkdir -p -CXXFLAGS = -Wall -I ../../lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions -LNKFLAGS = -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lcrtdll +CXXFLAGS = -mno-cygwin -Wall -I ../../lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions +LNKFLAGS = -mno-cygwin -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lcrtdll all: $(DLLFULLNAME) Index: plugins/newarc/src/plugins/rar/makefile_gcc =================================================================== --- plugins/newarc/src/plugins/rar/makefile_gcc (revision 1402) +++ plugins/newarc/src/plugins/rar/makefile_gcc (working copy) @@ -14,8 +14,8 @@ M4 = m4 -P MV = mv -f MKDIR = mkdir -p -CXXFLAGS = -Wall -I ../../lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions -LNKFLAGS = -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lcrtdll +CXXFLAGS = -mno-cygwin -Wall -I ../../lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions +LNKFLAGS = -mno-cygwin -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lcrtdll all: $(DLLFULLNAME) Index: plugins/newarc/src/plugins/7z.all/makefile_gcc =================================================================== --- plugins/newarc/src/plugins/7z.all/makefile_gcc (revision 1402) +++ plugins/newarc/src/plugins/7z.all/makefile_gcc (working copy) @@ -14,8 +14,8 @@ M4 = m4 -P MV = mv -f MKDIR = mkdir -p -CXXFLAGS = -Wall -Wno-non-virtual-dtor -I ../../lib.part/Include -Os -fno-strict-aliasing -funsigned-char -fomit-frame-pointer -fno-rtti -fno-exceptions -LNKFLAGS = -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lole32 -loleaut32 -lcrtdll -lgcc +CXXFLAGS = -mno-cygwin -Wall -Wno-non-virtual-dtor -I ../../lib.part/Include -Os -fno-strict-aliasing -funsigned-char -fomit-frame-pointer -fno-rtti -fno-exceptions +LNKFLAGS = -mno-cygwin -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lole32 -loleaut32 -lcrtdll -lgcc all: $(DLLFULLNAME) Index: plugins/newarc/src/plugins/targz/makefile_gcc =================================================================== --- plugins/newarc/src/plugins/targz/makefile_gcc (revision 1402) +++ plugins/newarc/src/plugins/targz/makefile_gcc (working copy) @@ -14,9 +14,9 @@ M4 = m4 -P MV = mv -f MKDIR = mkdir -p -CXXFLAGS = -Wall -I ../../lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions +CXXFLAGS = -mno-cygwin -Wall -I ../../lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions #LNKFLAGS = -s -nostartfiles $(LIBS) -luser32 -lkernel32 -ladvapi32 -lole32 -LNKFLAGS = -s -nostartfiles $(LIBS) +LNKFLAGS = -mno-cygwin -s -nostartfiles $(LIBS) #LNKFLAGS = -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lole32 all: $(DLLFULLNAME) Index: plugins/newarc/src/plugins/ace/makefile_gcc =================================================================== --- plugins/newarc/src/plugins/ace/makefile_gcc (revision 1402) +++ plugins/newarc/src/plugins/ace/makefile_gcc (working copy) @@ -14,8 +14,8 @@ M4 = m4 -P MV = mv -f MKDIR = mkdir -p -CXXFLAGS = -Wall -I ../../lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions -LNKFLAGS = -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lcrtdll +CXXFLAGS = -mno-cygwin -Wall -I ../../lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions +LNKFLAGS = -mno-cygwin -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lcrtdll all: $(DLLFULLNAME) Index: plugins/newarc/src/plugins/ma/makefile_gcc =================================================================== --- plugins/newarc/src/plugins/ma/makefile_gcc (revision 1402) +++ plugins/newarc/src/plugins/ma/makefile_gcc (working copy) @@ -14,8 +14,8 @@ M4 = m4 -P MV = mv -f MKDIR = mkdir -p -CXXFLAGS = -Wall -I ../../lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions -LNKFLAGS = -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lole32 -lcrtdll +CXXFLAGS = -mno-cygwin -Wall -I ../../lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions +LNKFLAGS = -mno-cygwin -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lole32 -lcrtdll all: $(DLLFULLNAME) Index: plugins/newarc/src/makefile_gcc =================================================================== --- plugins/newarc/src/makefile_gcc (revision 1402) +++ plugins/newarc/src/makefile_gcc (working copy) @@ -14,8 +14,8 @@ M4 = m4 -P MV = mv -f MKDIR = mkdir -p -CXXFLAGS = -Wall -I ./lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions -LNKFLAGS = -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lcrtdll -lole32 +CXXFLAGS = -mno-cygwin -Wall -I ./lib.part/Include -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions +LNKFLAGS = -mno-cygwin -s -nostartfiles -nodefaultlibs $(LIBS) -luser32 -lkernel32 -ladvapi32 -lcrtdll -lole32 all: $(DLLFULLNAME) Index: plugins/newarc/src/lib.part/makefile_gcc =================================================================== --- plugins/newarc/src/lib.part/makefile_gcc (revision 1402) +++ plugins/newarc/src/lib.part/makefile_gcc (working copy) @@ -14,7 +14,7 @@ MKDIR = mkdir -p AR = ar RANLIB = ranlib -CXXFLAGS = -Wall -I ./Include -Os -fno-strict-aliasing -funsigned-char -fomit-frame-pointer -fno-rtti -fno-exceptions +CXXFLAGS = -mno-cygwin -Wall -I ./Include -Os -fno-strict-aliasing -funsigned-char -fomit-frame-pointer -fno-rtti -fno-exceptions OBJS = $(patsubst %.cpp,$(OBJDIR)/%.o,$(filter %.cpp,$(SRCS))) DEPS = $(patsubst %.cpp,$(OBJDIR)/%.d,$(filter %.cpp,$(SRCS))) Index: plugins/common/CRT/makefile_lib_gcc =================================================================== --- plugins/common/CRT/makefile_lib_gcc (revision 1402) +++ plugins/common/CRT/makefile_lib_gcc (working copy) @@ -52,7 +52,7 @@ MKDIR = mkdir -p AR = ar RANLIB = ranlib -CXXFLAGS = -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions +CXXFLAGS = -mno-cygwin -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions OBJS = $(patsubst %.cpp,$(OBJDIR)/%.o,$(filter %.cpp,$(SRCS))) OBJSW = $(patsubst %.cpp,$(OBJDIRW)/%_w.o,$(filter %.cpp,$(SRCSW))) Index: plugins/makefile_gcc_def_inc =================================================================== --- plugins/makefile_gcc_def_inc (revision 1402) +++ plugins/makefile_gcc_def_inc (working copy) @@ -46,9 +46,9 @@ WINDRES = windres AR = ar RANLIB = ranlib -CXXFLAGS = -I $(COMMON) -I $(COMINC) -Wall -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions $(USERCPP) -CCFLAGS = -I $(COMMON) -I $(COMINC) -Wall -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-exceptions $(USERCPP) -LNKFLAGS = -mdll -s -nostartfiles -nodefaultlibs -lgcc $(USERLIBSFIRST) -L $(COMMON) -lCRT -luser32 -lkernel32 -ladvapi32 -lshell32 $(USERLIBS) +CXXFLAGS = -mno-cygwin -I $(COMMON) -I $(COMINC) -Wall -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-rtti -fno-exceptions $(USERCPP) +CCFLAGS = -mno-cygwin -I $(COMMON) -I $(COMINC) -Wall -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-exceptions $(USERCPP) +LNKFLAGS = -mno-cygwin -mdll -s -nostartfiles -nodefaultlibs -lgcc $(USERLIBSFIRST) -L $(COMMON) -lCRT -luser32 -lkernel32 -ladvapi32 -lshell32 $(USERLIBS) OBJS = $(patsubst %.cpp,$(OBJDIR)/%.o,$(filter %.cpp,$(SRCS))) $(RES) DEPS = $(patsubst %.cpp,$(OBJDIR)/%.d,$(filter %.cpp,$(SRCS))) Index: plugins/helloworld/makefile_gcc =================================================================== --- plugins/helloworld/makefile_gcc (revision 1402) +++ plugins/helloworld/makefile_gcc (working copy) @@ -8,8 +8,8 @@ CC = gcc DLLTOOL = dlltool RM = rm -f -CCFLAGS = -I $(COMMON) -I $(COMINC) -Wall -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-exceptions -LNKFLAGS = -mdll -s -nostartfiles -L $(COMMON) -lCRT +CCFLAGS = -mno-cygwin -I $(COMMON) -I $(COMINC) -Wall -Os -funsigned-char -fomit-frame-pointer -fstrict-aliasing -fno-exceptions +LNKFLAGS = -mno-cygwin -mdll -s -nostartfiles -L $(COMMON) -lCRT OBJS = $(patsubst %.c,%.o,$(filter %.c,$(SRCS))) MAP = $(patsubst %.dll,%.map,$(DLLNAME)) Index: unicode_far/makefile_gcc =================================================================== --- unicode_far/makefile_gcc (revision 1402) +++ unicode_far/makefile_gcc (working copy) @@ -131,9 +131,9 @@ MKDIR = mkdir -p WINDRES = windres DEFINES = -D USE_WFUNC -D FAR_ALPHA_VERSION -D USE_WFUNC_ALW -D USE_WFUNC_IN -CCFLAGS = -pipe -Os $(DEFINES) -funsigned-char -fomit-frame-pointer -fno-exceptions -fno-rtti -Wno-deprecated -CFLAGS = -pipe -Os $(DEFINES) -funsigned-char -fomit-frame-pointer -fno-exceptions -LNKFLAGS = -s -lmpr -lwinspool +CCFLAGS = -mno-cygwin -pipe -Os $(DEFINES) -funsigned-char -fomit-frame-pointer -fno-exceptions -fno-rtti -Wno-deprecated +CFLAGS = -mno-cygwin -pipe -Os $(DEFINES) -funsigned-char -fomit-frame-pointer -fno-exceptions +LNKFLAGS = -mno-cygwin -s -lmpr -lwinspool OBJS = $(patsubst %.cpp,$(OBJDIR)/%.o,$(filter %.cpp,$(SRCS))) $(patsubst %.c,$(OBJDIR)/%.o,$(filter %.c,$(SRCS))) $(OBJDIR)/far.rc.o DEPS = $(patsubst %.cpp,$(OBJDIR)/%.d,$(filter %.cpp,$(SRCS))) $(patsubst %.c,$(OBJDIR)/%.d,$(filter %.c,$(SRCS))) |
|
Fixed in 399. |
Date Modified | Username | Field | Change |
---|---|---|---|
2007-12-15 21:25 | AH | New Issue | |
2007-12-15 21:25 | AH | Status | new => assigned |
2007-12-15 21:25 | AH | Assigned To | => alexy |
2007-12-15 21:25 | AH | File Added: cygwin.diff | |
2008-01-04 09:27 | alexy | Note Added: 0001092 | |
2008-01-04 09:27 | alexy | Status | assigned => feedback |
2008-02-24 13:37 | alexy | Build | => 399 |
2008-02-24 13:37 | alexy | Status | feedback => closed |
2008-02-24 13:37 | alexy | Resolution | open => fixed |
2008-02-24 13:37 | alexy | Fixed in Version | => 1.80 alpha 1 |