View Issue Details

IDProjectCategoryView StatusLast Update
0000449Far ManagerHistorypublic2007-12-24 06:36
Reportervsergiy Assigned Tovskirdin  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Fixed in Version1.80 alpha 1 
Summary0000449: Handle leak in History::ReadHistory()
DescriptionHandle leak in History::ReadHistory() if "Lines" value contains no data.

Patch is attached.
TagsNo tags attached.
Build395

Activities

2007-12-23 02:42

 

history.cpp.patch (382 bytes)   
Index: history.cpp
===================================================================
--- history.cpp	(revision 1402)
+++ history.cpp	(working copy)
@@ -425,7 +425,10 @@
   Size=GetRegKeySize(hKey, L"Lines");
 
   if(!Size) // ���� ������
+  {
+    RegCloseKey(hKey);
     return TRUE;
+  }
 
   if((Buffer=(wchar_t*)xf_malloc(Size*sizeof (wchar_t))) == NULL)
   {
history.cpp.patch (382 bytes)   

vskirdin

2007-12-23 05:00

administrator   bugnote:0001065

см. после 395

Issue History

Date Modified Username Field Change
2007-12-23 02:42 vsergiy New Issue
2007-12-23 02:42 vsergiy File Added: history.cpp.patch
2007-12-23 04:58 vskirdin Status new => assigned
2007-12-23 04:58 vskirdin Assigned To => vskirdin
2007-12-23 05:00 vskirdin Note Added: 0001065
2007-12-23 05:00 vskirdin Status assigned => feedback
2007-12-24 01:48 vsergiy Status feedback => resolved
2007-12-24 01:48 vsergiy Resolution open => fixed
2007-12-24 06:36 vskirdin Build => 395
2007-12-24 06:36 vskirdin Status resolved => closed
2007-12-24 06:36 vskirdin Fixed in Version => 1.80 alpha 1