View Issue Details

IDProjectCategoryView StatusLast Update
0000822Far ManagerPlugins API.Old API Wrapperpublic2009-04-08 22:30
Reportersn2234 Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Fixed in Version2.0 
Summary0000822: Crashes with old plugins
DescriptionIn pluginold.hpp all structures have default members alignment, while some ASCII plugins (7-Zip for example) expect them aligned on 1 byte. This may lead to crashes in many cases.
Additional InformationAttached patch solve this problem for me.
TagsNo tags attached.
Build866

Activities

2009-04-08 22:24

 

sug.patch (396 bytes)   
Index: pluginold.hpp
===================================================================
--- pluginold.hpp	(revision 2821)
+++ pluginold.hpp	(working copy)
@@ -1,6 +1,8 @@
 #ifndef __PLUGINOLD_HPP__
 #define __PLUGINOLD_HPP__
 
+#pragma pack(push, 1)
+
 namespace oldfar
 {
 enum FARMESSAGEFLAGS{
@@ -1818,4 +1820,5 @@
 
 }
 
+#pragma pack(pop)
 #endif /* __PLUGINOLD_HPP__ */
sug.patch (396 bytes)   

Issue History

Date Modified Username Field Change
2009-04-08 22:24 sn2234 New Issue
2009-04-08 22:24 sn2234 File Added: sug.patch
2009-04-08 22:30 DrKnS Build => 866
2009-04-08 22:30 DrKnS Status new => closed
2009-04-08 22:30 DrKnS Resolution open => fixed
2009-04-08 22:30 DrKnS Fixed in Version => 2.0