View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001992 | Far Manager | Plugins Manager | public | 2012-01-16 20:21 | 2012-01-18 19:38 |
| Reporter | Maximus | Assigned To | vskirdin | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.0 | ||||
| Fixed in Version | 3.0 | ||||
| Summary | 0001992: Падение по F4 в F11/AltShiftF9 если все строки - в фильтре | ||||
| Description | Собственно не только F4 но и все что ссылается на "item" | ||||
| Steps To Reproduce | В панелях F11 (или AltShiftF9) CtrlAltF lajsg (чтобы ни одной строки не осталось) F4 | ||||
| Tags | No tags attached. | ||||
| Build | 2399 | ||||
|
|
Plugins120116.diff (2,905 bytes)
Index: plugins.cpp
===================================================================
--- plugins.cpp (revision 7287)
+++ plugins.cpp (working copy)
@@ -1496,24 +1496,27 @@
switch (Key)
{
case KEY_SHIFTF1:
- strPluginModuleName = item->pPlugin->GetModuleName();
+ if (item)
+ {
+ strPluginModuleName = item->pPlugin->GetModuleName();
- if (!FarShowHelp(strPluginModuleName,L"Config",FHELP_SELFHELP|FHELP_NOSHOWERROR) &&
- !FarShowHelp(strPluginModuleName,L"Configure",FHELP_SELFHELP|FHELP_NOSHOWERROR))
- {
- FarShowHelp(strPluginModuleName,nullptr,FHELP_SELFHELP|FHELP_NOSHOWERROR);
+ if (!FarShowHelp(strPluginModuleName,L"Config",FHELP_SELFHELP|FHELP_NOSHOWERROR) &&
+ !FarShowHelp(strPluginModuleName,L"Configure",FHELP_SELFHELP|FHELP_NOSHOWERROR))
+ {
+ FarShowHelp(strPluginModuleName,nullptr,FHELP_SELFHELP|FHELP_NOSHOWERROR);
+ }
}
break;
case KEY_F3:
- if (PluginList.GetItemCount() > 0 && SelPos<MenuItemNumber)
+ if (item)
{
ShowPluginInfo(item->pPlugin, item->Guid);
}
break;
case KEY_F4:
- if (PluginList.GetItemCount() > 0 && SelPos<MenuItemNumber)
+ if (item)
{
string strTitle;
int nOffset = HotKeysPresent?3:0;
@@ -1685,7 +1688,8 @@
{
case KEY_SHIFTF1:
// ������ ����� �����, ������ �������� � CommandsMenu()
- FarShowHelp(item->pPlugin->GetModuleName(),HistoryName,FHELP_SELFHELP|FHELP_NOSHOWERROR|FHELP_USECONTENTS);
+ if (item)
+ FarShowHelp(item->pPlugin->GetModuleName(),HistoryName,FHELP_SELFHELP|FHELP_NOSHOWERROR|FHELP_USECONTENTS);
break;
case KEY_ALTF11:
@@ -1695,14 +1699,14 @@
case KEY_F3:
- if (PluginList.GetItemCount() > 0 && SelPos<MenuItemNumber)
+ if (item)
{
ShowPluginInfo(item->pPlugin, item->Guid);
}
break;
case KEY_F4:
- if (PluginList.GetItemCount() > 0 && SelPos<MenuItemNumber)
+ if (item)
{
string strTitle;
int nOffset = HotKeysPresent?3:0;
@@ -1723,18 +1727,21 @@
case KEY_ALTSHIFTF9:
case KEY_RALTSHIFTF9:
{
- PluginList.Hide();
- NeedUpdateItems = true;
- StartPos = SelPos;
- PluginList.SetExitCode(SelPos);
- Configure();
- PluginList.Show();
+ if (item)
+ {
+ PluginList.Hide();
+ NeedUpdateItems = true;
+ StartPos = SelPos;
+ PluginList.SetExitCode(SelPos);
+ Configure();
+ PluginList.Show();
+ }
break;
}
case KEY_SHIFTF9:
{
- if (PluginList.GetItemCount() > 0 && SelPos<MenuItemNumber)
+ if (item)
{
NeedUpdateItems = true;
StartPos=SelPos;
|
|
|
build 2399 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-01-16 20:21 | Maximus | New Issue | |
| 2012-01-16 20:21 | Maximus | File Added: Plugins120116.diff | |
| 2012-01-17 08:10 | vskirdin | Note Added: 0008432 | |
| 2012-01-17 08:10 | vskirdin | Assigned To | => vskirdin |
| 2012-01-17 08:10 | vskirdin | Status | new => feedback |
| 2012-01-18 19:38 | alexy | Build | => 2399 |
| 2012-01-18 19:38 | alexy | Status | feedback => closed |
| 2012-01-18 19:38 | alexy | Resolution | open => fixed |
| 2012-01-18 19:38 | alexy | Fixed in Version | => 3.0 |
