View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003019 | Far Manager | Plugins API.Panel | public | 2015-07-10 16:30 | 2015-07-11 17:34 |
Reporter | victorp | Assigned To | shmuel | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 3.0 | ||||
Summary | 0003019: Number of custom columns is limited to 10 for plugin | ||||
Description | Some plugins (for example, FarSQLiteDB), could require more than 10 custom columns to show. 10 is limited in panelctype.hpp - CUSTOM_COLUMN0 to CUSTOM_COLUMN9, and further. | ||||
Steps To Reproduce | - Install FarSQLiteDB plugin (http://sourceforge.net/projects/farplugs/files/) - Open any SQLite database - Execute "select 1,2,3,4,5,6,7,8,9,10,11,12,13" See only first 10 columns aren't empty; data is missed for 11,12,13 columns. | ||||
Additional Information | Attached patch: not really a fix, but just an increase of really boring 10 columns to 20. | ||||
Tags | No tags attached. | ||||
Build | 4401 | ||||
|
custom_columns_increase.patch (2,066 bytes)
Index: filelist.cpp =================================================================== --- filelist.cpp (revision 13180) +++ filelist.cpp (working copy) @@ -3545,7 +3545,7 @@ { int ColumnType=static_cast<int>(ColumnTypes[K] & 0xff); int ColumnWidth=ColumnWidths[K]; - if (ColumnType>=CUSTOM_COLUMN0 && ColumnType<=CUSTOM_COLUMN9) + if (ColumnType >= CUSTOM_COLUMN0 && ColumnType < COLUMN_TYPES_COUNT) { size_t ColumnNumber=ColumnType-CUSTOM_COLUMN0; const wchar_t *ColumnData=nullptr; @@ -8291,7 +8291,7 @@ if (!ShowStatus) SetShowColor(ListPos); - if (ColumnType >= CUSTOM_COLUMN0 && ColumnType <= CUSTOM_COLUMN9) + if (ColumnType >= CUSTOM_COLUMN0 && ColumnType < COLUMN_TYPES_COUNT) { size_t ColumnNumber = ColumnType - CUSTOM_COLUMN0; const wchar_t *ColumnData = nullptr; Index: panelctype.hpp =================================================================== --- panelctype.hpp (revision 13180) +++ panelctype.hpp (working copy) @@ -61,6 +61,16 @@ CUSTOM_COLUMN7, CUSTOM_COLUMN8, CUSTOM_COLUMN9, + CUSTOM_COLUMN10, + CUSTOM_COLUMN11, + CUSTOM_COLUMN12, + CUSTOM_COLUMN13, + CUSTOM_COLUMN14, + CUSTOM_COLUMN15, + CUSTOM_COLUMN16, + CUSTOM_COLUMN17, + CUSTOM_COLUMN18, + CUSTOM_COLUMN19, COLUMN_TYPES_COUNT }; Index: panelmix.cpp =================================================================== --- panelmix.cpp (revision 13180) +++ panelmix.cpp (working copy) @@ -85,6 +85,16 @@ { CUSTOM_COLUMN7, 0, L"C7" }, { CUSTOM_COLUMN8, 0, L"C8" }, { CUSTOM_COLUMN9, 0, L"C9" }, + { CUSTOM_COLUMN10, 0, L"C10" }, + { CUSTOM_COLUMN11, 0, L"C11" }, + { CUSTOM_COLUMN12, 0, L"C12" }, + { CUSTOM_COLUMN13, 0, L"C13" }, + { CUSTOM_COLUMN14, 0, L"C14" }, + { CUSTOM_COLUMN15, 0, L"C15" }, + { CUSTOM_COLUMN16, 0, L"C16" }, + { CUSTOM_COLUMN17, 0, L"C17" }, + { CUSTOM_COLUMN18, 0, L"C18" }, + { CUSTOM_COLUMN19, 0, L"C19" }, }; static_assert(ARRAYSIZE(ColumnInfo) == COLUMN_TYPES_COUNT, "wrong size of ColumnInfo array"); |
|
Does FarSQLiteDB correctly show the contents of 13 columns with the patched FAR? Shouldn't the plugin be also modified to take advantage of additional custom columns? |
Date Modified | Username | Field | Change |
---|---|---|---|
2015-07-10 16:30 | victorp | New Issue | |
2015-07-10 16:30 | victorp | File Added: custom_columns_increase.patch | |
2015-07-10 17:15 | shmuel | Note Added: 0013692 | |
2015-07-11 17:34 | shmuel | Build | => 4401 |
2015-07-11 17:34 | shmuel | Status | new => closed |
2015-07-11 17:34 | shmuel | Assigned To | => shmuel |
2015-07-11 17:34 | shmuel | Resolution | open => fixed |